Skip to content

Commit

Permalink
ARM: dts: bcm2711: Fix xHCI power-domain
Browse files Browse the repository at this point in the history
During s2idle tests on the CM4 the VPU firmware always crashes
on xHCI power-domain resume:

root@raspberrypi:/sys/power# echo freeze > state
[   70.724347] xhci_suspend finished
[   70.727730] xhci_plat_suspend finished
[   70.755624] bcm2835-power bcm2835-power: Power grafx off
[   70.761127]  USB: Set power to 0

[   74.653040]  USB: Failed to set power to 1 (-110)

This seems to be caused because of the mixed usage of
raspberrypi-power and bcm2835-power at the same time. So avoid
the usage of the VPU firmware power-domain driver, which
prevents the crash.

Fixes: 522c35e ("ARM: dts: bcm2711: Add BCM2711 xHCI support")
Link: raspberrypi/linux#6537
Signed-off-by: Stefan Wahren <[email protected]>
  • Loading branch information
lategoodbye committed Dec 21, 2024
1 parent 08e788f commit 1334f8c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
5 changes: 0 additions & 5 deletions arch/arm/boot/dts/broadcom/bcm2711-rpi.dtsi
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
#include "bcm2835-rpi.dtsi"

#include <dt-bindings/power/raspberrypi-power.h>
#include <dt-bindings/reset/raspberrypi,firmware-reset.h>

/ {
Expand Down Expand Up @@ -101,7 +100,3 @@
&vchiq {
interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
};

&xhci {
power-domains = <&power RPI_POWER_DOMAIN_USB>;
};
1 change: 1 addition & 0 deletions arch/arm/boot/dts/broadcom/bcm2711.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,7 @@
#address-cells = <1>;
#size-cells = <0>;
interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&pm BCM2835_POWER_DOMAIN_USB>;
/* DWC2 and this IP block share the same USB PHY,
* enabling both at the same time results in lockups.
* So keep this node disabled and let the bootloader
Expand Down

0 comments on commit 1334f8c

Please sign in to comment.