Added List component to the sistent components page #6086

csengineer1990 · 2024-11-20T08:12:11Z

Description

This PR fixes #5951
By adding the List component to the Sistent Components page.
The required content and documentation for the List component have been included, along with updates to the necessary files.

Notes for Reviewers
I have made the following changes:
Added the List of component implementation and documentation.
Updated the related files to reflect these changes.
Could you review the updates and let me know if any additional changes or content updates are required?

Signed commits

Yes, I signed my commits.

Signed-off-by: Roshan Goswami <[email protected]>

Signed-off-by: Roshan <[email protected]>

l5io · 2024-11-20T09:42:30Z

🚀 Preview for commit 9f5a6b7 at: https://673daeac4ab01b5bf2a3bc3c--layer5.netlify.app

mdkaifansari04 · 2024-11-20T12:27:02Z

You can consider adding all Types of List component into that navigation-menu

csengineer1990 · 2024-11-20T13:05:16Z

You can consider adding all Types of List components into that navigation-menu

@mdkaifansari04
Thank you for the feedback!

I’m not entirely sure where you’d like me to make the suggested changes regarding adding all types of List components to the navigation menu. Could you please provide more clarification?
Additionally, I noticed that the attached image isn’t visible on my end. If possible, could you reattach it or provide additional details? That would help me make the necessary updates more effectively.

Thank you!

mdkaifansari04 · 2024-11-20T13:10:03Z

If you look up to this side navigation menu, it has one menu as List Component. Try adding more menu items that is been presented in the overview section

sudhanshutech · 2024-11-21T11:24:11Z

change the structure of page as per new changes made around adding sistent components

Signed-off-by: Roshan Goswami <[email protected]>

csengineer1990 · 2024-11-22T04:21:31Z

If you look up to this side navigation menu, it has one menu as List Component. Try adding more menu items that is been presented in the overview section

Please check I have made the changes.

l5io · 2024-11-22T04:37:25Z

🚀 Preview for commit 3ab022b at: https://674009ea0d52eefebdee81a6--layer5.netlify.app

csengineer1990 · 2024-11-23T04:34:06Z

change the structure of page as per new changes made around adding sistent components

Could you please elaborate on what you mean by changing the structure of the page with the new Sistent components? I’d appreciate it if you could guide me on where exactly the changes need to be made or what specific updates are required. This will help me ensure that I address your requirements accurately. Thank you!

sudhanshutech · 2024-11-23T14:30:24Z

change the structure of page as per new changes made around adding sistent components

Could you please elaborate on what you mean by changing the structure of the page with the new Sistent components? I’d appreciate it if you could guide me on where exactly the changes need to be made or what specific updates are required. This will help me ensure that I address your requirements accurately. Thank you!

you don't have to create dir under pages , it will automatically created.

vishalvivekm · 2024-11-25T10:14:26Z

@csengineer1990
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

Signed-off-by: l5io <[email protected]>

Signed-off-by: Roshan Goswami <[email protected]>

Signed-off-by: l5io <[email protected]>

Vidit-Kushwaha · 2024-12-13T12:32:41Z

@csengineer1990 We will be having a sistent tutorial on this coming Monday (16 Dec 2024) ; this might help you to merge your PR

Vidit-Kushwaha · 2024-12-13T12:36:24Z

src/pages/projects/sistent/components/list/code.js

@@ -0,0 +1,8 @@
+import React from "react";


This file is not required, as pages will be dynamically created. so you don't require to create any pages under this dirc src/pages/projects/sistent/components/list/

Vidit-Kushwaha · 2024-12-13T12:36:50Z

src/pages/projects/sistent/components/list/guidance.js

Vidit-Kushwaha · 2024-12-13T12:37:11Z

src/pages/projects/sistent/components/list/index.js

Same as above stated

Vidit-Kushwaha · 2024-12-13T12:39:29Z

src/sections/Projects/Sistent/components/index.js

Rather than putting list data on componentsData, their is another file called content.js under same dirc src/sections/Projects/Sistent/components/ you have to put necessay data.

ok sir I will check and make the required changes.

Vidit-Kushwaha

I have included a few reviews.

Signed-off-by: l5io <[email protected]>

Signed-off-by: Roshan Goswami <[email protected]>

csengineer1990 · 2024-12-16T04:37:45Z

I am currently working on addressing the requested changes based on the review. This includes resolving some conflicts and updating the repository. The pull request is still open, and I am actively working on completing it. Thank you for your patience.

Signed-off-by: l5io <[email protected]>

Signed-off-by: Roshan Goswami <[email protected]>

Signed-off-by: l5io <[email protected]>

…nges Signed-off-by: Roshan Goswami <[email protected]>

l5io · 2024-12-19T11:32:32Z

🚀 Preview for commit cc194c9 at: https://6764040ae6e81c05629a77b2--layer5.netlify.app

l5io · 2024-12-19T11:32:35Z

🚀 Preview for commit cc194c9 at: https://676404061e55280ef5313a0a--layer5.netlify.app

csengineer1990 · 2024-12-22T13:51:36Z

Could you kindly review it again? I have made the changes as per your previous feedback. If I missed anything or made any mistakes, please let me know and guide me on how I can correct them.

sudhanshutech · 2024-12-23T05:06:39Z

@csengineer1990
Let's discuss this during the website call today at 6:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

Vidit-Kushwaha · 2024-12-23T12:55:13Z

feature_data.json

revert this file, i.e. feature_data.json

Vidit-Kushwaha · 2024-12-23T12:55:26Z

src/sections/Pricing/feature_data.json

Vidit-Kushwaha · 2024-12-23T13:02:10Z

src/sections/Projects/Sistent/components/list/code.js

+
+const codes = [
+  // Basic List with List Items
+  `  <SistentThemeProvider>


Can you remove SistentThemeProvider from code example blocks

Suggested change

` <SistentThemeProvider>

` <SistentThemeProvider>

Vidit-Kushwaha · 2024-12-23T13:15:48Z

src/sections/Projects/Sistent/components/list/code.js

their is a a and unwanted indentation under the code section of the list It appears to be unpleasant.

Vidit-Kushwaha · 2024-12-23T13:26:40Z

src/sections/Projects/Sistent/components/list/index.js

+          />
+        </div>
+        <div className="main-content">
+          <a id="List Components">


Hey, can you remove the unnecessary anchor tag in the list page? One minor recommendation is that the title will always appear in the sidebar when it is placed inside the h2 tag. Make sure you use it sensibly. only put important heading

Suggested change

<a id="List Components">

<a id="List Components">

Vidit-Kushwaha · 2024-12-23T13:30:43Z

src/sections/Projects/Sistent/components/list/index.js

+            <li>List Subheader: Provides a labeled header for grouping related list items.</li>
+
+          </ul>
+          <a id="Types of List component">


How a link should be added to the sidebar

Suggested change

<a id="Types of List component">

<a id="Types of List component">

Suggested change

<a id="Types of List component">

<a id="Types of List component">

<h3> Types of List component </h3>

</a>

Vidit-Kushwaha

Hey @csengineer1990 I have reviewed your PR and provided some feedback

Signed-off-by: Roshan Goswami <[email protected]>

l5io · 2024-12-25T12:31:07Z

🚀 Preview for commit 3722bc5 at: https://676bfac048e734388c266c4d--layer5.netlify.app

…and Pricing to 51c0889

csengineer1990 · 2024-12-25T13:07:18Z

Hey @csengineer1990 I have reviewed your PR and provided some feedback

I’ve made the changes as per your feedback, including updates to the index and code.js files. I’ve also reverted the feature_data.json file at both locations. Please review and let me know if anything needs further adjustment, or if I made any mistakes while reverting the file.

l5io · 2024-12-25T13:16:56Z

🚀 Preview for commit eb021c2 at: https://676c057a6c5eeb40be80cd4f--layer5.netlify.app

Signed-off-by: l5io <[email protected]>

Vidit-Kushwaha

It Looks good to me

Vidit-Kushwaha · 2024-12-27T12:48:25Z

src/sections/Projects/Sistent/components/list/code.js

+  </List> `,
+  // List with Action Buttons
+  `  <List>
+        <ListItemButton onClick={() => alert("Clicked!")}> Layer5 Sistent Action 1</ListItemButton>


@csengineer1990 If you could provide a nested list code example, here is example link

Added List component to the sistent components page

96771e4

Signed-off-by: Roshan Goswami <[email protected]>

github-actions bot added area/projects An issue relating to Layer5 initiatives (projects) project/sistent labels Nov 20, 2024

Merge branch 'master' into master

9f5a6b7

Signed-off-by: Roshan <[email protected]>

Updates in List component to the sistent components page

eb49d84

Signed-off-by: Roshan Goswami <[email protected]>

Merge branch 'layer5io:master' into master

3ab022b

l5io and others added 7 commits November 26, 2024 00:50

Updated feature data from source repository

458e7c1

Signed-off-by: l5io <[email protected]>

Updated feature data from source repository

ba2ea46

Signed-off-by: l5io <[email protected]>

Updated feature data from source repository

d28c247

Signed-off-by: l5io <[email protected]>

"Update id for 'List' component in componentsData array index file."

041ab14

Signed-off-by: Roshan Goswami <[email protected]>

Merge branch 'master' of https://github.com/csengineer1990/layer5

fe0b59a

Updated feature data from source repository

41ee8a9

Signed-off-by: l5io <[email protected]>

Updated feature data from source repository

458e964

Signed-off-by: l5io <[email protected]>

leecalcote requested a review from Vidit-Kushwaha December 9, 2024 20:34

Vidit-Kushwaha reviewed Dec 13, 2024

View reviewed changes

src/pages/projects/sistent/components/list/guidance.js Outdated

Copy link

Contributor

Vidit-Kushwaha Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Vidit-Kushwaha reviewed Dec 13, 2024

View reviewed changes

src/pages/projects/sistent/components/list/index.js Outdated

Copy link

Contributor

Vidit-Kushwaha Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above stated

Vidit-Kushwaha reviewed Dec 13, 2024

View reviewed changes

Vidit-Kushwaha suggested changes Dec 13, 2024

View reviewed changes

l5io and others added 4 commits December 15, 2024 19:54

Solved Conflict and Updated feature data from source repository

f4ca16e

Signed-off-by: l5io <[email protected]>

Updated feature data from source repository

b05dbba

Signed-off-by: l5io <[email protected]>

To solve conflict removed Dirctory and files

d2fe14d

Signed-off-by: Roshan Goswami <[email protected]>

Merge branch 'layer5io:master' into master

fddf86f

l5io and others added 6 commits December 17, 2024 00:52

Updated feature data from spreadsheet

bc3c90d

Signed-off-by: l5io <[email protected]>

Merge branch 'layer5io:master' into master

374d2cf

Merge branch 'layer5io:master' into master

3d8042a

To solve conflict update the index.js file.

c351c30

Signed-off-by: Roshan Goswami <[email protected]>

Updated feature data from spreadsheet

7bca8c5

Signed-off-by: l5io <[email protected]>

Added List component to the sistent components page with required cha…

cc194c9

…nges Signed-off-by: Roshan Goswami <[email protected]>

csengineer1990 reopened this Dec 19, 2024

Vidit-Kushwaha reviewed Dec 23, 2024

View reviewed changes

feature_data.json Outdated

Copy link

Contributor

Vidit-Kushwaha Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this file, i.e. feature_data.json

Vidit-Kushwaha reviewed Dec 23, 2024

View reviewed changes

src/sections/Pricing/feature_data.json Outdated

Copy link

Contributor

Vidit-Kushwaha Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Vidit-Kushwaha reviewed Dec 23, 2024

View reviewed changes

Vidit-Kushwaha suggested changes Dec 23, 2024

View reviewed changes

Update: Adjusted index and code files for the List component.

3722bc5

Signed-off-by: Roshan Goswami <[email protected]>

Reverted feature_data.json files to previous states: root to b05dbba …

eb021c2

…and Pricing to 51c0889

Updated feature data from spreadsheet

cf56fc3

Signed-off-by: l5io <[email protected]>

Vidit-Kushwaha reviewed Dec 27, 2024

View reviewed changes

	<a id="Types of List component">
	<a id="Types of List component">

Added List component to the sistent components page #6086

Are you sure you want to change the base?

Added List component to the sistent components page #6086

Conversation

csengineer1990 commented Nov 20, 2024

l5io commented Nov 20, 2024

mdkaifansari04 commented Nov 20, 2024

csengineer1990 commented Nov 20, 2024

mdkaifansari04 commented Nov 20, 2024

sudhanshutech commented Nov 21, 2024

csengineer1990 commented Nov 22, 2024

l5io commented Nov 22, 2024

csengineer1990 commented Nov 23, 2024

sudhanshutech commented Nov 23, 2024

vishalvivekm commented Nov 25, 2024

Vidit-Kushwaha commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

csengineer1990 commented Dec 16, 2024 • edited Loading

l5io commented Dec 19, 2024

l5io commented Dec 19, 2024

csengineer1990 commented Dec 22, 2024

sudhanshutech commented Dec 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

l5io commented Dec 25, 2024

csengineer1990 commented Dec 25, 2024

l5io commented Dec 25, 2024

Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

csengineer1990 commented Dec 16, 2024 •

edited

Loading