FIX: Session TTL incorrect when date string is provided in config #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crosa7
force-pushed
the
fix-session-lifetime-incorrect-when-string-provided
branch
2 times, most recently
from
6fd732a to
337bab0
Compare
crosa7
force-pushed
the
fix-session-lifetime-incorrect-when-string-provided
branch
from
337bab0 to
6178ac6
Compare
mychidarko
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When passing for example '1 day' in SESSION_LIFETIME it would result in a wrong session ttl. The result would be the current time + the timestamp of tomorrow.
Example: Let's consider the current timestamp: 1696600085 and the timestamp of tomorrow: 1696682885. The session ttl was resulting in: 3393282970