Enable usage of KOLIBRI_HOME as relative path "~/.my_home" #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jredrejo
reviewed
May 12, 2020
|
|
||
| if [ -e /etc/kolibri/daemon.conf ] | ||
| then | ||
| . /etc/kolibri/daemon.conf | ||
| fi | ||
|
|
||
|
|
||
| # It should be possible to use "~/.kolibri" for a relative |
There was a problem hiding this comment.
Could you ellaborate a bit more this sentence?
Why should ~/.kolibri be usable in a config file? I don't think it's a good idea, maybe that would explain the "various" reasons afterwards.
There was a problem hiding this comment.
It also ensures that someone who assumes ~/ to work won't have to spend time resolving that it doesn't work :)
Why should ~/.kolibri be usable in a config file?
Isn't it normal for HOME-relative paths to work in config files? Try sudo grep -r "~\/" /etc
rtibbles
force-pushed
the
master
branch
4 times, most recently
from
b6ec929 to
35cdac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to: https://github.com/learningequality/kolibri-server/pull/53/files#r412375303