-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated NewPasswordPage.vue with password visibility toggle #12878
Open
Dhanushcdivakar
wants to merge
2
commits into
learningequality:develop
Choose a base branch
from
Dhanushcdivakar:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: 'Manage Labels for External Contributors' | ||
description: 'Add or remove labels when external contributors are assigned or unassigned.' | ||
|
||
inputs: | ||
github_token: | ||
description: 'GitHub Token for authentication' | ||
required: true | ||
default: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
runs: | ||
using: 'python' | ||
main: 'manage_labels.py' | ||
|
||
# Add other configuration based on your requirements | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
const core = require('@actions/core'); | ||
const github = require('@actions/github'); | ||
|
||
async function run() { | ||
try { | ||
const token = core.getInput('repo-token'); | ||
const octokit = github.getOctokit(token); | ||
const { context } = github; | ||
|
||
const issueNumber = context.issue.number; | ||
const assignee = context.payload.assignee; | ||
const owner = context.repo.owner; | ||
const repo = context.repo.repo; | ||
|
||
// Check if the assignee is an external contributor (not a member or owner) | ||
const { data: collaborators } = await octokit.rest.repos.listCollaborators({ | ||
owner, | ||
repo, | ||
}); | ||
|
||
const isExternalContributor = !collaborators.some( | ||
(collab) => collab.login === assignee.login && (collab.role === 'member' || collab.role === 'owner') | ||
); | ||
|
||
if (isExternalContributor) { | ||
// Add the label | ||
await octokit.rest.issues.addLabels({ | ||
owner, | ||
repo, | ||
issue_number: issueNumber, | ||
labels: ['community-contribution-in-progress'], | ||
}); | ||
} else { | ||
// Remove the label | ||
await octokit.rest.issues.removeLabel({ | ||
owner, | ||
repo, | ||
issue_number: issueNumber, | ||
name: 'community-contribution-in-progress', | ||
}); | ||
} | ||
} catch (error) { | ||
core.setFailed(error.message); | ||
} | ||
} | ||
|
||
run(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to be sure that the message here is translated for all users, you'd need to add two new messages in the
$trs
property of the component, one each for "Hide password" and "Show password". Then you can conditionalize which message to show by referencing the keys of the objects you add to$trs
in a call to$tr(<the key of the message object you made>)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could pass the KButton's label to the
:text
prop instead of to the default slot as you have here. It may be cleaner to do this because we also need to put the same text on the KButton'saria-label
attribute as well