Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required sanity check flags to ensure deletion of testpypi artifacts #12978

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jan 7, 2025

Summary

  • Adds the two required flags --do-it and --yes to make the pypi-cleanup command run a destructive operation
  • Pins the pypi-cleanup library to a specific version to avoid accidents from API changes

References

https://github.com/learningequality/kolibri/actions/runs/12150283948/job/33882727667

…cts.

Pin version to protect against API changes.
@github-actions github-actions bot added the DEV: dev-ops Continuous integration & deployment label Jan 7, 2025
@marcellamaki marcellamaki self-assigned this Jan 7, 2025
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-referenced with pypi-cleanup docs and both flags here (as well as what's referenced in the error message) seem to be the correct options.

@rtibbles rtibbles merged commit 8263a97 into learningequality:develop Jan 8, 2025
36 of 37 checks passed
@rtibbles rtibbles deleted the clean_up_pypi branch January 8, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: dev-ops Continuous integration & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants