Merge remote-tracking branch 'upstream/unstable' into merge-into-sear…

…ch-recs
learningequality · Sep 18, 2024 · 2df4aae · 2df4aae
2 parents 812a390 + 45bf94e
commit 2df4aae
Show file tree

Hide file tree

Showing 47 changed files with 2,189 additions and 903 deletions.
diff --git a/.github/workflows/notify_team_new_comment.yml b/.github/workflows/notify_team_new_comment.yml
@@ -27,7 +27,7 @@ jobs:
         env:
             SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
             SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
-        uses: slackapi/slack-github-action@v1.26.0
+        uses: slackapi/slack-github-action@v1.27.0
         with:
           payload: |
             {

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/Clipboard/Channel.vue b/contentcuration/contentcuration/frontend/channelEdit/components/Clipboard/Channel.vue
@@ -12,6 +12,7 @@
           <Checkbox
             ref="checkbox"
             class="ma-0 pa-0"
+            :class="{ selectedIndeterminate: !selected && indeterminate }"
             :inputValue="selected"
             :indeterminate="indeterminate"
             @input="goNextSelectionState"
@@ -140,4 +141,8 @@
     line-height: 1.3 !important;
   }
 
+  /deep/ .selectedIndeterminate svg {
+    fill: gray !important;
+  }
+
 </style>
diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/Clipboard/ContentNode.vue b/contentcuration/contentcuration/frontend/channelEdit/components/Clipboard/ContentNode.vue
@@ -32,6 +32,7 @@
                       <Checkbox
                         ref="checkbox"
                         class="mt-0 pt-0"
+                        :class="{ selectedIndeterminate: !selected && indeterminate }"
                         :inputValue="selected"
                         :indeterminate="indeterminate"
                         @input="goNextSelectionState"
@@ -303,4 +304,8 @@
     line-height: 1.3 !important;
   }
 
+  /deep/ .selectedIndeterminate svg {
+    fill: gray !important;
+  }
+
 </style>
diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/ContentNodeEditListItem.vue b/contentcuration/contentcuration/frontend/channelEdit/components/ContentNodeEditListItem.vue
@@ -45,7 +45,7 @@
         </template>
 
         <template #actions-end>
-          <VListTileAction class="action-icon px-1" @click.stop>
+          <VListTileAction v-if="canEdit" class="action-icon px-1" @click.stop>
             <transition name="fade">
               <IconButton
                 icon="rename"

diff --git a/...on/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue b/...on/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
@@ -1,8 +1,10 @@
+
 <template>
 
   <KModal
     :title="title"
     :submitText="$tr('saveAction')"
+    :submitDisabled="!canSave"
     :cancelText="$tr('cancelAction')"
     data-test="edit-booleanMap-modal"
     @submit="handleSave"
@@ -11,6 +13,9 @@
     <p v-if="resourcesSelectedText.length > 0" data-test="resources-selected-message">
       {{ resourcesSelectedText }}
     </p>
+    <p v-if="hasMixedCategories" data-test="mixed-categories-message">
+      {{ hasMixedCategoriesMessage }}
+    </p>
     <template v-if="isDescendantsUpdatable && isTopicSelected">
       <KCheckbox
         :checked="updateDescendants"
@@ -26,9 +31,6 @@
       :inputHandler="(value) => { selectedValues = value }"
     ></slot>
 
-    <span v-if="error" class="red--text">
-      {{ error }}
-    </span>
   </KModal>
 
 </template>
@@ -45,6 +47,7 @@
   import { mapGetters, mapActions } from 'vuex';
   import { ContentKindsNames } from 'shared/leUtils/ContentKinds';
   import { getInvalidText } from 'shared/utils/validation';
+  import commonStrings from 'shared/translator';
 
   export default {
     name: 'EditBooleanMapModal',
@@ -91,16 +94,27 @@
          */
         selectedValues: {},
         changed: false,
+        hasMixedCategories: false,
       };
     },
     computed: {
-      ...mapGetters('contentNode', ['getContentNodes']),
+      ...mapGetters('contentNode', ['getContentNodes', 'getContentNode']),
       nodes() {
         return this.getContentNodes(this.nodeIds);
       },
       isTopicSelected() {
         return this.nodes.some(node => node.kind === ContentKindsNames.TOPIC);
       },
+      canSave() {
+        if (this.hasMixedCategories) {
+          return Object.values(this.selectedValues).some(value => value.length > 0);
+        }
+        return !this.error;
+      },
+      hasMixedCategoriesMessage() {
+        // eslint-disable-next-line kolibri/vue-no-undefined-string-uses
+        return commonStrings.$tr('addAdditionalCatgoriesDescription');
+      },
     },
     watch: {
       selectedValues(newValue, oldValue) {
@@ -121,6 +135,9 @@
       });
 
       this.selectedValues = optionsNodes;
+      this.hasMixedCategories = Object.values(this.selectedValues).some(
+        value => value.length < this.nodes.length
+      );
       // reset
       this.$nextTick(() => {
         this.changed = false;
@@ -147,19 +164,20 @@
         }
       },
       async handleSave() {
-        this.validate();
-        if (this.error) {
-          return;
-        }
-
         await Promise.all(
-          this.nodes.map(node => {
+          this.nodes.map(async node => {
             const fieldValue = {};
-            Object.entries(this.selectedValues).forEach(([key, value]) => {
-              if (value.includes(node.id)) {
+            const currentNode = this.getContentNode(node.id);
+            // If we have mixed categories remain the old ones, and
+            // just add new categories if there are any
+            if (this.hasMixedCategories) {
+              Object.assign(fieldValue, currentNode[this.field] || {});
+            }
+            Object.entries(this.selectedValues)
+              .filter(([value]) => value.length === this.nodeIds.length)
+              .forEach(([key]) => {
                 fieldValue[key] = true;
-              }
-            });
+              });
             if (this.updateDescendants && node.kind === ContentKindsNames.TOPIC) {
               return this.updateContentNodeDescendants({
                 id: node.id,

diff --git a/...tion/contentcuration/frontend/channelEdit/components/QuickEditModal/EditLanguageModal.vue b/...tion/contentcuration/frontend/channelEdit/components/QuickEditModal/EditLanguageModal.vue
@@ -42,6 +42,7 @@
         v-model="selectedLanguage"
         :buttonValue="language.id"
         :label="languageText(language)"
+        :labelDir="null"
       />
       <p
         v-if="!languageOptions.length"
@@ -178,7 +179,7 @@
         'You selected resources in different languages. The language you choose below will be applied to all selected resources.',
       updateDescendantsCheckbox:
         'Apply the chosen language to all resources, folders, and subfolders contained within the selected folders.',
-      emptyLanguagesSearch: 'No languages matches the search',
+      emptyLanguagesSearch: 'No language matches the search',
     },
   };
 

diff --git a/...ration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditSourceModal.vue b/...ration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditSourceModal.vue
@@ -2,7 +2,6 @@
 
   <div>
     <KModal
-      v-if="!isAboutLicensesModalOpen"
       :title="$tr('editAttribution')"
       :submitText="$tr('saveAction')"
       :cancelText="$tr('cancelAction')"
@@ -170,7 +169,6 @@
       /* eslint-enable  kolibri/vue-no-unused-properties */
     },
     computed: {
-      ...mapGetters(['isAboutLicensesModalOpen']),
       ...mapGetters('contentNode', ['getContentNodes']),
       ...mapFormGettersSetters(sourceKeys),
       nodes() {

diff --git a/...tion/frontend/channelEdit/components/QuickEditModal/__tests__/EditBooleanMapModal.spec.js b/...tion/frontend/channelEdit/components/QuickEditModal/__tests__/EditBooleanMapModal.spec.js
@@ -16,7 +16,6 @@ let generalActions;
 const CheckboxValue = {
   UNCHECKED: 'UNCHECKED',
   CHECKED: 'CHECKED',
-  INDETERMINATE: 'INDETERMINATE',
 };
 
 const { translateMetadataString } = metadataTranslationMixin.methods;
@@ -31,11 +30,9 @@ const getOptionsValues = wrapper => {
   const categories = {};
   const checkboxes = wrapper.findAll('[data-test="option-checkbox"]');
   checkboxes.wrappers.forEach(checkbox => {
-    const { label, checked, indeterminate } = checkbox.vm.$props || {};
+    const { label, checked } = checkbox.vm.$props || {};
     let value;
-    if (indeterminate) {
-      value = CheckboxValue.INDETERMINATE;
-    } else if (checked) {
+    if (checked) {
       value = CheckboxValue.CHECKED;
     } else {
       value = CheckboxValue.UNCHECKED;
@@ -182,26 +179,6 @@ describe('EditBooleanMapModal', () => {
         expect(dailyLifeValue).toBe(CheckboxValue.CHECKED);
         expect(foundationsValue).toBe(CheckboxValue.CHECKED);
       });
-
-      test('checkbox option should be indeterminate if not all nodes have the same options set', () => {
-        nodes['node1'].categories = {
-          [Categories.DAILY_LIFE]: true,
-          [Categories.FOUNDATIONS]: true,
-        };
-        nodes['node2'].categories = {
-          [Categories.DAILY_LIFE]: true,
-        };
-
-        const wrapper = makeWrapper({ nodeIds: ['node1', 'node2'] });
-
-        const optionsValues = getOptionsValues(wrapper);
-        const {
-          [Categories.DAILY_LIFE]: dailyLifeValue,
-          [Categories.FOUNDATIONS]: foundationsValue,
-        } = optionsValues;
-        expect(dailyLifeValue).toBe(CheckboxValue.CHECKED);
-        expect(foundationsValue).toBe(CheckboxValue.INDETERMINATE);
-      });
     });
   });
 

diff --git a/...curation/frontend/channelEdit/components/QuickEditModal/__tests__/EditSourceModal.spec.js b/...curation/frontend/channelEdit/components/QuickEditModal/__tests__/EditSourceModal.spec.js
@@ -9,7 +9,6 @@ let nodes;
 let store;
 let contentNodeActions;
 let generalActions;
-let generalGetters;
 
 const MIXED_VALUE = 'Mixed';
 
@@ -64,12 +63,8 @@ describe('EditSourceModal', () => {
     generalActions = {
       showSnackbarSimple: jest.fn(),
     };
-    generalGetters = {
-      isAboutLicensesModalOpen: () => false,
-    };
     store = new Vuex.Store({
       actions: generalActions,
-      getters: generalGetters,
       modules: {
         contentNode: {
           namespaced: true,

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue b/contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
@@ -122,9 +122,6 @@
           </VFlex>
         </VLayout>
       </BottomBar>
-      <AboutLicensesModal
-        v-if="isAboutLicensesModalOpen"
-      />
       <InheritAncestorMetadataModal
         :parent="(createMode && detailNodeIds.length) ? parent : null"
         @inherit="inheritMetadata"
@@ -195,7 +192,6 @@
   import { fileSizeMixin, routerMixin } from 'shared/mixins';
   import FileStorage from 'shared/views/files/FileStorage';
   import MessageDialog from 'shared/views/MessageDialog';
-  import AboutLicensesModal from 'shared/views/AboutLicensesModal';
   import ResizableNavigationDrawer from 'shared/views/ResizableNavigationDrawer';
   import Uploader from 'shared/views/files/Uploader';
   import LoadingText from 'shared/views/LoadingText';
@@ -226,7 +222,6 @@
       SavingIndicator,
       ToolBar,
       BottomBar,
-      AboutLicensesModal,
     },
     mixins: [fileSizeMixin, routerMixin],
     props: {
@@ -260,7 +255,6 @@
       };
     },
     computed: {
-      ...mapGetters(['isAboutLicensesModalOpen']),
       ...mapGetters('contentNode', ['getContentNode', 'getContentNodeIsValid']),
       ...mapGetters('assessmentItem', ['getAssessmentItems']),
       ...mapGetters('currentChannel', ['currentChannel', 'canEdit']),

diff --git a/...ion/contentcuration/frontend/channelEdit/components/edit/InheritAncestorMetadataModal.vue b/...ion/contentcuration/frontend/channelEdit/components/edit/InheritAncestorMetadataModal.vue
@@ -296,7 +296,7 @@
         'All future additions to this folder will have the selected details by default',
       language: 'Language: {language}',
       categories: 'Categories: {categories}',
-      learnerNeeds: 'Learner needs: {learnerNeeds}',
+      learnerNeeds: 'Requirements: {learnerNeeds}',
       levels: 'Levels: {levels}',
     },
   };

diff --git a/contentcuration/contentcuration/frontend/channelEdit/getters.js b/contentcuration/contentcuration/frontend/channelEdit/getters.js
@@ -10,10 +10,6 @@ export function isComfortableViewMode(state) {
   return viewMode === viewModes.COMFORTABLE;
 }
 
-export function isAboutLicensesModalOpen(state) {
-  return state.aboutLicensesModalOpen;
-}
-
 // Convenience function to format strings like "Page Name - Channel Name"
 // for tab titles
 export function appendChannelName(state, getters) {

diff --git a/contentcuration/contentcuration/frontend/channelEdit/mutations.js b/contentcuration/contentcuration/frontend/channelEdit/mutations.js
@@ -5,7 +5,3 @@ export function SET_VIEW_MODE(state, viewMode) {
 export function SET_VIEW_MODE_OVERRIDES(state, overrides) {
   state.viewModeOverrides = overrides;
 }
-
-export function SET_SHOW_ABOUT_LICENSES(state, isOpen) {
-  state.aboutLicensesModalOpen = isOpen;
-}
diff --git a/contentcuration/contentcuration/frontend/channelEdit/store.js b/contentcuration/contentcuration/frontend/channelEdit/store.js
@@ -31,8 +31,6 @@ export const STORE_CONFIG = {
        * to override the current `viewMode`.
        */
       viewModeOverrides: [],
-
-      aboutLicensesModalOpen: false,
     };
   },
   actions,

diff --git a/contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue b/contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue
@@ -165,11 +165,7 @@
             @deselect="selected = selected.filter(id => id !== $event)"
             @scroll="scroll"
             @editTitleDescription="showTitleDescriptionModal"
-          >
-            <template #pagination>
-              <slot name="pagination"></slot>
-            </template>
-          </NodePanel>
+          />
         </DraggableRegion>
       </VFadeTransition>
       <ResourceDrawer

diff --git a/...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchResultsList.vue b/...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchResultsList.vue
@@ -33,7 +33,7 @@
               </span>
               <ActionLink
                 class="mx-2"
-                :disabled="searchIsNotEmpty || currentSearchSaved"
+                :disabled="currentSearchSaved"
                 :text="currentSearchSaved ? $tr('searchSavedSnackbar') : $tr('saveSearchAction')"
                 @click="handleClickSaveSearch"
               />