Merge pull request #74 from waylaidwanderer/patch-1

Fix identifierRegex failing because of Steam upgrading http requests with TLS
liamcurry · Apr 6, 2018 · 97ea178 · 97ea178
2 parents 559ea32 + fbcf2f3
commit 97ea178
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/passport-steam/strategy.js b/lib/passport-steam/strategy.js
@@ -76,7 +76,7 @@ function getUserProfile(key, steamID, callback) {
  */
 function Strategy(options, validate) {
   options = options || {};
-  options.providerURL = options.providerURL || 'http://steamcommunity.com/openid';
+  options.providerURL = options.providerURL || 'https://steamcommunity.com/openid';
   options.profile =  (options.profile === undefined) ? true : options.profile;
   options.stateless = true; //Steam only works as a stateless OpenID
 
@@ -85,7 +85,7 @@ function Strategy(options, validate) {
 
   function verify(req, identifier, profile, done) {
     var validOpEndpoint = 'https://steamcommunity.com/openid/login';
-    var identifierRegex = /^http:\/\/steamcommunity\.com\/openid\/id\/(\d+)$/;
+    var identifierRegex = /^https?:\/\/steamcommunity\.com\/openid\/id\/(\d+)$/;
 
     if(req.query['openid.op_endpoint'] !== validOpEndpoint ||
        !identifierRegex.test(identifier)) {

diff --git a/test/strategy.test.js b/test/strategy.test.js
@@ -11,7 +11,7 @@ function getStrategy () {
 }
 
 test("Whether the providerURL is steam's", t => {
-  t.same(getStrategy()._providerURL, 'http://steamcommunity.com/openid')
+  t.same(getStrategy()._providerURL, 'https://steamcommunity.com/openid')
 });
 
 test("Whether the strategy name is 'steam'", t => {