Skip to content

Commit

Permalink
ci: don't run changelog check on chores and refactor PRs
Browse files Browse the repository at this point in the history
We don't always want to write a changelog entry or bump the version of a crate when we make changes to it. This especially applies to refactorings and other chores. We can automatically detect such PRs based on our conventional commit title.

At the moment, this is not per crate but could be extended in the future. For now, this should be good enough to unblock PRs that are currently stuck on this workflow.

Pull-Request: #4658.
  • Loading branch information
thomaseizinger authored Oct 16, 2023
1 parent 29c44e8 commit c91ecbc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@ jobs:
test "$PACKAGE_VERSION" = "$SPECIFIED_VERSION"
- name: Ensure manifest and CHANGELOG are properly updated
if: github.event_name == 'pull_request'
if: >
github.event_name == 'pull_request' &&
!startsWith(github.event.pull_request.title, 'chore') &&
!startsWith(github.event.pull_request.title, 'refactor')
run: |
git fetch origin master:master
./scripts/ensure-version-bump-and-changelog.sh
Expand Down
6 changes: 0 additions & 6 deletions protocols/kad/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@

[PR 4547]: https://github.com/libp2p/rust-libp2p/pull/4547

<!-- Internal changes:
- Fix lints in tests
-->

## 0.44.5
- Migrate to `quick-protobuf-codec` crate for codec logic.
See [PR 4501].
Expand Down

0 comments on commit c91ecbc

Please sign in to comment.