-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set fixed locale for numbers near config read/write #15782
Conversation
This has just been fixed on liblocale here: https://gitlab.freedesktop.org/libdecor/libdecor/-/merge_requests/132 |
58cad13
to
6431eff
Compare
As discussed under the issue, this change in the current form will avoid the libdecor related problem. Full solution would be locale independent read/write, that is a bigger undertaking, but maybe the issue could remain open as a reminder. |
This might be of interest for this issue:
|
I do not see a way how to avoid the warning from RA, unfortunately. Gtk is not used directly from this codebase. |
Move setlocale() closer to config file read/write.
6431eff
to
14843e3
Compare
Change is now limited to the problematic configuration. |
Sorry for the long wait. |
Same thing here
|
Description
Force a fixed locale for numbers. This is a fallback measure when a rogue library modifies the locale, which should be "C" by default.
Related Issues
#15756
In this particular issue, the chain was wayland -> libdecor -> gtk plugin -> setlocale(LC_ALL, "")
There may be some other issues related to this, as the error causes bad reading/writing of floats, leading to all sorts of weird controller setups.