Exclude "System Volume Information" explicitly from directory listing #15833
Conversation
|
OK, just one thought, would it make sense to put this behind a |
|
I think this applies to any FAT device that's been touched by Windows at least once, right? So it applies to non-Windows settings, as well? |
|
It is not needed when RA is running on Windows, since in that case hidden directories are filtered using the attributes: It can be put behind something like: |
|
I guess if it applies to any FAT device it might make sense to keep it the way it is I guess as @hizzlekizzle suggested. |
|
It applies to any FAT device being read from something else than Windows. |
|
right, so if anything, it would be #if !defined __WIN32, since Windows already hides it. |
Description
Okay, bear with me for a moment. It is not as bad of a hack as it looks like, though I can understand if this gets rejected.
I started investigating #15831 and found out that there is no straightforward way to get the hidden attribute of FAT file systems on non-Windows systems. (I would say specifically for PS2 in the current SDK there is no way, since it instructs to use stat() that does not transfer this attribute).
But even a non-Windows RA install can meet such entry if an USB drive is used under Windows and then loaded to RA, such as transferring ROMs to an embedded system: a directory called "System Volume Information" will appear in the root. IMO it makes sense to treat this special entry as a hidden one. A few lines earlier, entries starting with dot are also excluded without regard to platform, although they do not hold special meaning under Windows.
Note: RA compiled for Windows excludes actual hidden entries elsewhere (in retro_vfs_opendir_impl() ).
Related Issues
#15831
Related Pull Requests
#14724 has brought a change in behavior on PS2, but it was also wrong earlier, just in a different way, so this is no reason to revert that (and it fixes a lot of other things). Current PS2 RA behavior is consistent with a desktop Linux RA install.