(cheevos) allow subframes in hardcore #17296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
changed the title
|
Thanks for handling this even though you didn't add it yourself :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Video subframes are not currently allowed in hardcore mode. The restriction was added in the original PR adding the subframe feature.
As this functionality is required for the new rolling scanline shader code, I've been asked to remove it.
I don't believe this restriction was ever discussed with us, and brief testing suggests it's not necessary. If I crank the value up to its max, I only see about 3fps, but the system still appears to be running at 60fps. If anything, the game is harder to play in this mode.
Related Issues
https://discord.com/channels/184109094070779904/584075942276628481/1321479164582428692
Related Pull Requests
n/a
Reviewers
@LibretroAdmin @Sanaki @hunterk