Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled CRTSwitchres support for KMS DRM video #17353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kozakt
Copy link

@kozakt kozakt commented Jan 6, 2025

Description

Switchres now supports DRM KMS linux video driver, this change will enable support for it in RetroArch builds.

@substring
Copy link
Contributor

Hi,

This is not necessary, KMS/DRM modeswitching works perfectly without this PR, adding this file could be dangerous. In KMS/DRM, Switchres is used as a modeline generator and doesn't need to handle anything else since Retroarch is bare metal enough to do the modeswitching itself once it has the modeline -> see #15131 KMS modeswitching works since March 2023

The file you're adding requires a patched kernel that with user modes added through an IOCTL, which is the case absolutely no main distro, just a few niche ones (or people compiling their own kernel).

@kozakt
Copy link
Author

kozakt commented Jan 6, 2025

Well, I'm testing with Raspberry Pi 5 and command line only Raspberry Pi LIte and mode switching doesn't work without this change. Also, I'm not patching kernel or anything, just stock Raspberry Pi LIte OS.
With this change, mode switching actually starting to work properly.

@substring
Copy link
Contributor

Better investigate why it doesn't work without this. Ping me on discord. I tested the KMS modeswitching on Pi4 as well as PC when I wrote it.

@LibretroAdmin
Copy link
Contributor

Seems to be a build error for CI Linux (i686)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants