Skip to content

Commit

Permalink
corpus: remove submodule
Browse files Browse the repository at this point in the history
A Git submodule was introduced in commit 341ac1e
("corpus: initial integration"). The main idea was to keep in sync
source code of tests and their seed corpus.
However, this approach is not convenient:

- seed corpus updates often and someone need to regularly bump
  submodule version, otherwise outdated seed corpus is used
- seed corpus takes about 5Gb and git clone of repository with
  tests takes significant time
  • Loading branch information
ligurio committed Nov 30, 2024
1 parent 4fc4f85 commit 3c65c94
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 9 deletions.
1 change: 0 additions & 1 deletion .clusterfuzzlite/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ RUN apt-get update && apt-get install -y \

COPY . $SRC/lua-c-api-tests
WORKDIR $SRC/lua-c-api-tests
RUN rm -rf corpus
RUN git clone --depth 1 --branch cfl https://github.com/ligurio/lua-c-api-corpus corpus
COPY .clusterfuzzlite/build.sh $SRC/
3 changes: 0 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
submodules: recursive

- name: Setup common packages
run: |
Expand Down
3 changes: 0 additions & 3 deletions .gitmodules

This file was deleted.

4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ LuaJIT).
### Building

```sh
git clone --jobs $(nproc) --recursive https://github.com/ligurio/lua-c-api-tests
git clone https://github.com/ligurio/lua-c-api-tests
cd lua-c-api-tests
git clone https://github.com/ligurio/lua-c-api-corpus
CC=clang CXX=clang++ cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DUSE_LUA=ON [-DUSE_LUAJIT=ON]
cmake --build build --parallel
```
Expand Down
1 change: 0 additions & 1 deletion corpus
Submodule corpus deleted from a82313

0 comments on commit 3c65c94

Please sign in to comment.