Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA-1355 fix upload request total max size #970

Merged
merged 2 commits into from
Nov 22, 2024
Merged

LA-1355 fix upload request total max size #970

merged 2 commits into from
Nov 22, 2024

Conversation

KhaledNjim
Copy link
Collaborator

@KhaledNjim KhaledNjim commented Nov 20, 2024 •
edited
Loading

GitLab ticket

Root cause

  • The current conditions compare values that might be in different units
  • The error message contains a hardcoded value of 100GB, which might not reflect the actual limit.

Solution

  • Converted both the input value and limit to bytes before comparing.
  • Added parameters for the l10n string to display the actual limit.

Demo

1355.mp4

@KhaledNjim KhaledNjim requested a review from hoangdat November 20, 2024 21:40
@KhaledNjim KhaledNjim changed the title LA-1355 fix pull request total max size LA-1355 fix upload request total max size Nov 20, 2024
@hoangdat
Copy link
Member

please rebase

@KhaledNjim KhaledNjim force-pushed the LA-1355_pull_request_total_size branch from 5e9f7a3 to a967b21 Compare November 21, 2024 10:36
@KhaledNjim
Copy link
Collaborator Author

please rebase

Done

@hoangdat hoangdat merged commit fa2a3ea into master Nov 22, 2024
4 checks passed
@hoangdat hoangdat deleted the LA-1355_pull_request_total_size branch November 22, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhaledNjim @hoangdat