Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos and update URLs #497

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Benjamin-Loison
Copy link
Contributor

No description provided.

@Benjamin-Loison Benjamin-Loison changed the title Correct 4 typos and update 4 URLs Correct typos and update URLs Oct 30, 2023
@petefoth
Copy link
Contributor

Thanks for these changes. I did proof-read the document changes I made for typos, but it is had (impossible?) to spot your own mistakes :)

Would you be willing to review future documentation changes that I make before I merge them? I don't like merging changes - even documentation-only changes - without review, but at the moment I there is no-one I can call on to review them.

I will merge this PR.

Thanks again

@petefoth petefoth merged commit e63f87f into lineageos4microg:master Oct 30, 2023
2 checks passed
@Benjamin-Loison
Copy link
Contributor Author

Benjamin-Loison commented Oct 30, 2023

@petefoth

I have not used the Markdown editor MarkText for this commit (hence #499), but with its spell checker (on Linux Mint in my case) already raises some typos such as:

  • buid
  • intallation
  • knowlegdeable

In addition to find out incorrect commas use:

grep -E " ,|,'" README.md

I just established (hence #499) the following command-line to check URL updates:

grep -Eo "(http|https)://[a-zA-Z0-9./?=_%:-]*" README.md | sort -u | xargs -i sh -c 'curl -s -I "{}" | grep -wq "301" && echo "{}" && curl -s -I "{}" | grep location | cut -d ':' -f2-'

currently outputting:

https://docs.docker.com/docker-for-mac/install/
 /desktop/install/mac-install/
https://docs.docker.com/docker-for-windows/install/
 /desktop/install/windows-install/
https://docs.docker.com/install/linux/docker-ce/centos/
 /engine/install/centos/
https://docs.docker.com/install/linux/docker-ce/debian/
 /engine/install/debian/
https://docs.docker.com/install/linux/docker-ce/fedora/
 /engine/install/fedora/
https://docs.docker.com/install/linux/docker-ce/ubuntu/
 /engine/install/ubuntu/
https://docs.docker.com/toolbox/overview/
 /desktop/
https://github.com/microg/android_packages_apps_GmsCore/wiki/Signature-Spoofing
 https://github.com/microg/GmsCore/wiki/Signature-Spoofing
https://source.android.com/setup/build/building
 /docs/setup/build/building

Anyway I'm fine with reviewing documentation changes, just assign me as a reviewer.

@petefoth
Copy link
Contributor

In addition to find out incorrect commas use:

grep -E " ,|,'" README.md

It might be a good plan to integrate those into a check that gets run automatically whenever README.mdis checked in.

I have no idea how to do that, but I'll raise an issue and maybe I'll find out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants