chore: change rust-toolchain file to toml format
#11528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rust-toolchain` file containing only a Rust version number is deprecated in favor of a TOML-formatted `rust-toolchain.toml`. Using the old format seems to make Dependabot unhappy --- it complains that: ``` only rust-toolchain files formatted as TOML are supported, the non-TOML format was deprecated by Rust ``` Therefore, this branch changes the toolchain file in this repo to the TOML format. This required updating the CI workflows that check that the toolchain matches to use a new regex.
adleong
approved these changes
Oct 23, 2023
mateiidavid
approved these changes
Oct 24, 2023
hawkw
added a commit
that referenced
this pull request
Oct 26, 2023
PR #11528 changed the `rust-toolchain` file to use the TOML format rather than the plaintext format. Unfortunately, this broke the `test-policy` CI job, which `cat`s the contents of the `rust-toolchain` file to determine which Rust version to install, and that file now no longer exists (since it's now in `rust-toolchain.toml`). See: https://github.com/linkerd/linkerd2/actions/runs/6649430068/job/18068192854?pr=11535 This branch fixes that by changing the CI job to use a regex to extract the Rust toolchain version instead.
mateiidavid
pushed a commit
that referenced
this pull request
Oct 27, 2023
PR #11528 changed the `rust-toolchain` file to use the TOML format rather than the plaintext format. Unfortunately, this broke the `test-policy` CI job, which `cat`s the contents of the `rust-toolchain` file to determine which Rust version to install, and that file now no longer exists (since it's now in `rust-toolchain.toml`). See: https://github.com/linkerd/linkerd2/actions/runs/6649430068/job/18068192854?pr=11535 This branch fixes that by changing the CI job to use a regex to extract the Rust toolchain version instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rust-toolchainfile containing only a Rust version number is deprecated in favor of a TOML-formattedrust-toolchain.toml. Using the old format seems to make Dependabot unhappy --- it complains that:Therefore, this branch changes the toolchain file in this repo to the TOML format. This required updating the CI workflows that check that the toolchain matches to use a new regex.