Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viz): add option to add labels to web service #13305

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Conversation

omer2500
Copy link
Contributor

@omer2500 omer2500 commented Nov 11, 2024

Problem
There is no option to add labels to the dashboard service (web) specifically
for example, the use case of service mirror the dashboard service to make it accessible in another cluster needs the label:

mirror.linkerd.io/exported: 'true'

Solution
Add option to add labels to dashboard service only

Validation
Run helm templates with couple of use cases to verify it adds new properties while not overwrite others.

I agree to the DCO for all the commits in this PR.

@omer2500 omer2500 requested a review from a team as a code owner November 11, 2024 13:07
@omer2500
Copy link
Contributor Author

Hi,

Will be great to get feedback about this :)

thanks

@cratelyn
Copy link
Contributor

cratelyn commented Dec 2, 2024

Hi,

Will be great to get feedback about this :)

thanks

hi @omer2500! thanks for your patience, our team has been a bit busy getting a few new features out the door, followed by the u.s. holiday last week.

it looks like the first place to start would be to update the helm docs, which are checked into git as a README.md. you should be able to fix that by running helm docs from your branch and checking in any resulting changes.

Signed-off-by: Alex Leong <[email protected]>
@adleong adleong changed the title feat: viz: add option to add labels to web service feat(viz): add option to add labels to web service Dec 12, 2024
@adleong adleong merged commit c16f08c into linkerd:main Dec 12, 2024
22 checks passed
@omer2500
Copy link
Contributor Author

Thanks for the fix and the merge @adleong i actually wanted to ask what was wrong on the helm docs it seems just the version was changed? am i missing something ?

@adleong
Copy link
Member

adleong commented Dec 12, 2024

@omer2500 that's right, we recently updated the version of our helm tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants