fix: Updated OBJ plugin default cluster configurataion to be required #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
zliang-akamai and
ykim-akamai
and removed request for
a team
zliang-akamai
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Requires that the user configures a default cluster when running
linode-cli obj mbto prevent error.✔️ How to Test
The following steps assume you have pulled down this PR locally and ran
make install.Integration Tests
make MODULE=obj testintUnit Tests
make testunitManual Tests
Run
linode-cli obj mb bug-testand try not providing a default cluster to verify that the user is prompted for it again.📷 Preview