Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] E2E test case for VPC route controller #280

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[testing] E2E test case for VPC route controller #280

merged 2 commits into from
Dec 19, 2024

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented Dec 19, 2024

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

rahulait
rahulait reviewed Dec 19, 2024
View reviewed changes
e2e/test/route-controller-test/chainsaw-test.yaml Outdated

check:
($error == null): true
(contains($stdout, 'Pod CIDR found in VPC interface configuration')): true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are looking at each node, if any one fails to find the CIDR in ip_ranges, it will still consider it success. Maybe we should check (contains($stdout, 'Pod CIDR not found in VPC interface configuration')): false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Lets switch it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

rahulait
rahulait approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulait rahulait merged commit 51eaadd into main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulait rahulait rahulait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@komer3 @rahulait