Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HACS show details/readme on SmartIR landing page #138

Closed
wants to merge 5 commits into from
Closed

Make HACS show details/readme on SmartIR landing page #138

wants to merge 5 commits into from

Conversation

icefest
Copy link

@icefest icefest commented Sep 26, 2024

HACS doesn't show details on SmartIR landing page.

I'm fairly sure that HACS will only display the README.md as the display file, and only if the json file is also updated.

I've renamed info.md to README.md, to allow HACS to display it,
I've edited hacs.json to tell HACS to display it.

see issue #136, with screenshot of results from this edit.

@litinoveweedle
Copy link
Owner

Hello, thank you for the PR, unfortunately it is failing due to hacs.json syntax:

"render_readme": "true",

shall be

"render_readme": true,

Could you please update your PR?

@litinoveweedle
Copy link
Owner

Another fancy thing, render_readme seems not to be documented anyore!

@litinoveweedle
Copy link
Owner

In addition info.md is not complete readme. Maybe it would be better, to move docs/README.md into root and delete info.md (as it is only subset of the README.md)

@icefest
Copy link
Author

icefest commented Sep 26, 2024

Alright,

Did some digging, render_readme was used in an older version of HACS, and now has no function anymore - I'll delete it!

In addition info.md is not complete readme. Maybe it would be better, to move docs/README.md into root and delete info.md (as it is only subset of the README.md)

wilco

@litinoveweedle
Copy link
Owner

Thank you, but seems, that there is merge conflict. Probably because of the previous merge (which had change in the doc/README.md) not being in your repo. Could you please try to fix it?

@icefest icefest closed this by deleting the head repository Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants