-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a rds-instance-stop chaos fault #710
Open
jongwooo
wants to merge
1
commit into
litmuschaos:master
Choose a base branch
from
jongwooo:add-a-rds-instance-stop-chaos-fault
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add a rds-instance-stop chaos fault #710
jongwooo
wants to merge
1
commit into
litmuschaos:master
from
jongwooo:add-a-rds-instance-stop-chaos-fault
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongwooo
force-pushed
the
add-a-rds-instance-stop-chaos-fault
branch
4 times, most recently
from
September 7, 2024 13:04
e2df90a
to
4ea0caf
Compare
Logs:
|
jongwooo
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
September 7, 2024 13:17
jongwooo
commented
Sep 8, 2024
experimentDetails.InstanceID = types.Getenv("INSTANCE_ID", "") | ||
experimentDetails.ChaosPodName = types.Getenv("POD_NAME", "") | ||
experimentDetails.Delay, _ = strconv.Atoi(types.Getenv("STATUS_CHECK_DELAY", "2")) | ||
experimentDetails.Timeout, _ = strconv.Atoi(types.Getenv("STATUS_CHECK_TIMEOUT", "600")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stopping an RDS instance takes about 10 minutes. Therefore, I set STATUS_CHECK_TIMEOUT
to 600.
jongwooo
force-pushed
the
add-a-rds-instance-stop-chaos-fault
branch
5 times, most recently
from
October 22, 2024 06:46
1589961
to
2d922fb
Compare
Signed-off-by: Jongwoo Han <[email protected]>
jongwooo
force-pushed
the
add-a-rds-instance-stop-chaos-fault
branch
from
October 22, 2024 06:47
2d922fb
to
33d4d7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I have implemented the rds-instance-stop chaos fault in this PR based on the proposal.
Please see also litmuschaos/chaos-charts#635
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
cc. @namkyu1999
Checklist:
breaking-changes
tagrequires-upgrade
tag