Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add participant attributes to the FFI #367

Merged
merged 9 commits into from
Jul 15, 2024
Merged

Add participant attributes to the FFI #367

merged 9 commits into from
Jul 15, 2024

Conversation

keepingitneil
Copy link
Contributor

@keepingitneil keepingitneil commented Jul 12, 2024 •
edited
Loading

Also:

  • rename update_name/attributes/metadata -> set_name/attributes/metadata for consistency with client-sdk-js
  • add async getRoomSid to FFI

@keepingitneil keepingitneil marked this pull request as draft July 12, 2024 20:40
@keepingitneil keepingitneil marked this pull request as ready for review July 12, 2024 21:15
davidzhao
davidzhao reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic lgtm. will leave the approval to someone who's more fluent with the Rust stack

livekit-ffi/src/server/room.rs Outdated
));
});
server.watch_panic(handle);
proto::UpdateLocalAttributesResponse { async_id }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more of a question/note about request/response semantics in the FFI layer

we are planning to allow set_attributes/set_metadata to be able to return failure & error string. This could be due to the participant not having permission to update that field. How do we reflect these errors on the Rust/FFI side?

Copy link
Member

@theomonnom theomonnom Jul 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust FFI is already exposing the error, but this PR ignores it above

@keepingitneil keepingitneil force-pushed the neil/attrs branch 2 times, most recently from 6d5db88 to 5323320 Compare July 15, 2024 20:54
theomonnom
theomonnom approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise.
use cargo fmt

@keepingitneil keepingitneil merged commit 7f14113 into main Jul 15, 2024
1 check passed
@keepingitneil keepingitneil deleted the neil/attrs branch July 15, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

@davidzhao davidzhao davidzhao left review comments

@nbsp nbsp Awaiting requested review from nbsp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keepingitneil @davidzhao @theomonnom