Fix deleteSipDispatchRule and TransformCall.clone (#87)

* Fix deleteSipDispatchRule and TransformCall.clone * changeset * Add spotlessCheck to CI
livekit · Oct 8, 2024 · 669ebe8 · 669ebe8
1 parent 9d06d5b
commit 669ebe8
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 4 deletions.
diff --git a/.changeset/giant-seals-compete.md b/.changeset/giant-seals-compete.md
@@ -0,0 +1,5 @@
+---
+"server-sdk-kotlin": patch
+---
+
+Fix clone function for transformed calls
diff --git a/.changeset/gorgeous-knives-bow.md b/.changeset/gorgeous-knives-bow.md
@@ -0,0 +1,5 @@
+---
+"server-sdk-kotlin": patch
+---
+
+Fix deleteSipDispatchRule
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -45,6 +45,15 @@ jobs:
     - name: Grant execute permission for gradlew
       run: chmod +x gradlew
 
+    - name: Gradle clean
+      run: ./gradlew clean
+
+    - name: Spotless check
+      if: github.event_name == 'pull_request'
+      run: |
+        git fetch origin main --depth 1
+        ./gradlew spotlessCheck
+
     - name: Build with Gradle
       run: ./gradlew assemble
 

diff --git a/src/main/kotlin/io/livekit/server/SipService.kt b/src/main/kotlin/io/livekit/server/SipService.kt
@@ -16,7 +16,6 @@
 
 package io.livekit.server
 
-import com.google.protobuf.Empty
 import livekit.LivekitSip
 import retrofit2.Call
 import retrofit2.http.Body
@@ -79,7 +78,7 @@ interface SipService {
     ): Call<LivekitSip.ListSIPDispatchRuleResponse>
 
     @Headers("Content-Type: application/protobuf")
-    @POST("/twirp/livekit.SIP/CreateSIPDispatchRule")
+    @POST("/twirp/livekit.SIP/DeleteSIPDispatchRule")
     fun deleteSipDispatchRule(
         @Body request: LivekitSip.DeleteSIPDispatchRuleRequest,
         @Header("Authorization") authorization: String
@@ -98,5 +97,4 @@ interface SipService {
         @Body request: LivekitSip.TransferSIPParticipantRequest,
         @Header("Authorization") authorization: String
     ): Call<Void?>
-
 }
diff --git a/src/main/kotlin/io/livekit/server/retrofit/TransformCall.kt b/src/main/kotlin/io/livekit/server/retrofit/TransformCall.kt
@@ -28,7 +28,7 @@ import retrofit2.Response
 internal class TransformCall<T, R>(private val sourceCall: Call<T>, private val transform: (T) -> R) :
     Call<R> {
     override fun clone(): Call<R> {
-        return TransformCall(sourceCall, transform)
+        return TransformCall(sourceCall.clone(), transform)
     }
 
     override fun execute(): Response<R> {