Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai/live: Configure parameters from auth callback #3264

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Nov 21, 2024

Adds a JSON schema for the auth callback, wires it up to the rest of the inference params and incorporates a couple more of the query strings. Take note of the field naming - pipeline and pipeline_params , happy to adjust those if preferred - eg, to match the existing model_id fields

Also some minor refactor to move the AI fields for aiRequestParams into its own struct to keep things tidy since I think we will be adding a bunch more things there later.

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 4.83871% with 59 lines in your changes missing coverage. Please review.

Project coverage is 34.60438%. Comparing base (cf051dd) to head (22ebe6f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_mediaserver.go 0.00000% 42 Missing ⚠️
server/auth.go 21.42857% 9 Missing and 2 partials ⚠️
server/ai_live_video.go 0.00000% 5 Missing ⚠️
server/ai_process.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3264         +/-   ##
===================================================
- Coverage   34.63487%   34.60438%   -0.03049%     
===================================================
  Files            136         136                 
  Lines          36316       36348         +32     
===================================================
  Hits           12578       12578                 
- Misses         23025       23055         +30     
- Partials         713         715          +2     
Files with missing lines Coverage Δ
server/ai_process.go 0.61082% <0.00000%> (ø)
server/ai_live_video.go 0.00000% <0.00000%> (ø)
server/auth.go 63.82979% <21.42857%> (-4.77486%) ⬇️
server/ai_mediaserver.go 8.06452% <0.00000%> (-0.45130%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf051dd...22ebe6f. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_process.go 0.61082% <0.00000%> (ø)
server/ai_live_video.go 0.00000% <0.00000%> (ø)
server/auth.go 63.82979% <21.42857%> (-4.77486%) ⬇️
server/ai_mediaserver.go 8.06452% <0.00000%> (-0.45130%) ⬇️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Collaborator

@eliteprox eliteprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with local authwebhook values and works great

@j0sh
Copy link
Collaborator Author

j0sh commented Nov 21, 2024

MacOS builds are broken because of some brew thing, merging for now to unblock #3263

@j0sh j0sh merged commit 66b00ce into master Nov 21, 2024
18 of 19 checks passed
@j0sh j0sh deleted the ja/configure-from-auth branch November 21, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants