Ensure disabled attr actually disables the button
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will start with an easy one :) |
|
@type1fool I snuck it a small extra change. I stopped disabling the sign in button. This should never be disabled. |
This reverts commit c3109e5.
…update-registration-component-assigns-correctly
type1fool
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Thank you @peaceful-james for catching this and opening a PR. I added a couple commits to make some small adjustments, and merged some CI fixes from main.
| @@ -39,7 +39,7 @@ | |||
| <p>Sign into an existing account:</p> | |||
|
|
|||
| <.live_component | |||
| disabled={@form.source.valid? == false} | |||
| disabled={false} | |||
peaceful-james
deleted the
update-registration-component-assigns-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70