76 Separate Authentication & Registration Views #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #76
The default Phoenix auth generator established a pattern of creating one LiveView for registration and a second for authentication. This is common practice in web apps.
To follow this pattern and to make the generated code a bit clearer, this PR splits up registration and authentication into two LiveViews.
Changes
0.8.0
Tests
This was tested on a local dev machine using a fresh Phoenix app in webauthn_components_demo. See PR 20.
🟡 Note that when using a local path dependency in Mix, the JS hooks have to be imported from the
webauthn_components/priv/static
directory, wherever it may be. This is a manual step for now.Collaborators