Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR] Remove also the !cir.void return type from the textual IR #1249

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keryell
Copy link
Collaborator

@keryell keryell commented Dec 19, 2024

This is the second phase of #1203, as the first phase has demonstrated that fixing the IR to avoid breaking an MLIR invariant can work.
Now, to avoid adding a new feature in the MLIR parser infrastructure, we change the way CIR IR textual representation is done by removing also !void or !cir.void in the function return types to just follow the normal way the other dialects work to represent function types.
See #1203 (comment) for more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant