PR for llvm/llvm-project#72621 #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes clangd/clangd#1743 Differential Revision: https://reviews.llvm.org/D158851 (cherry picked from commit 1994e1173b64b61c07f8acf107f29c2c015575b4)
|
@sam-mccall What do you think about merging this PR to the release branch? |
|
@sam-mccall @kadircet @HighCommander4 ok to backport? |
I'm the requestor so I'm not sure if my approval counts, but yes: this is low risk (adding a null pointer check) and fixes a clangd crash. |
|
yeah also LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves llvm/llvm-project#72621