[cmake] Enable accepting external stablehlo project #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@powderluv can you please help review? |
This MR enables `torch_mlir` project to accept path to external stablehlo and include those directories. This in turn enables `torch_mlir` to be part of bigger compiler project when `stablehlo` is already a dependency.
shelkesagar29
force-pushed
the
build_system
branch
from
09e7068 to
e782023
Compare
stellaraccident
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
@marbre for visibility (he was talking about possibly modernizing some of the cmake goo around this)
marbre
reviewed
Dec 20, 2024
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/externals/stablehlo) | ||
| if (NOT "${TORCH_MLIR_EXTERNAL_STABLEHLO_DIR}" STREQUAL "") | ||
| # Only include directories. It is assumed that stablehlo targets are made available by external project. | ||
| include_directories(${TORCH_MLIR_EXTERNAL_STABLEHLO_DIR}) |
There was a problem hiding this comment.
I would have assumed that the external project also makes the includes available.
marbre
reviewed
Dec 20, 2024
Comment on lines
+244
to
+247
| if (NOT "${TORCH_MLIR_EXTERNAL_STABLEHLO_DIR}" STREQUAL "") | ||
| # Only include directories. It is assumed that stablehlo targets are made available by external project. | ||
| include_directories(${TORCH_MLIR_EXTERNAL_STABLEHLO_DIR}) | ||
| else() |
There was a problem hiding this comment.
Actually
Suggested change
| if (NOT "${TORCH_MLIR_EXTERNAL_STABLEHLO_DIR}" STREQUAL "") | |
| # Only include directories. It is assumed that stablehlo targets are made available by external project. | |
| include_directories(${TORCH_MLIR_EXTERNAL_STABLEHLO_DIR}) | |
| else() | |
| # Only configure StableHLO if it isn't provided from a top-level project | |
| if ("${TORCH_MLIR_EXTERNAL_STABLEHLO_DIR}" STREQUAL "") |
should be sufficient. In that case I would probably replace the string with a boolean as it seems that the string isn't used elsewhere.
Depending on how the super project is set up (and pulls in torch-mlir and stablehlo) we could consider to add a TORCH_BUILD_EMBEDDED option, as some parts in the current out-of tree build config might be in responsibility of the super project as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR enables
torch_mlirproject to accept path to external stablehlo and include those directories. This in turn enablestorch_mlirto be part of bigger compiler project whenstablehlois already adependency.