Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync API Keys and Userdefaults using iCloud #97

Closed
wants to merge 65 commits into from

Conversation

frostplexx
Copy link
Member

No description provided.

@frostplexx frostplexx linked an issue Oct 7, 2023 that may be closed by this pull request
@frostplexx frostplexx added the feature/enhancement New feature or request label Oct 7, 2023
Copy link

@ojseftest ojseftest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Kinark and others added 23 commits October 27, 2023 21:00
No longer needed
Remove "Gift" error message, cherry pick web view for comments
fix black text in comments on dark mode
- Subreddit icons on all/home
- Quote text fixes
- Fixing comment likes
Merge pull request lo-cafe#229 from Frostplexx/main
- extends functionality of api call to support submissions and comments explicitly
- adds button functionality to post/comment karma button that filters user data feed
- adds spinner when selecting new filter
- clears feed when new filter is selected
Kinark and others added 26 commits November 16, 2023 00:46
 - Used [weak self] to prevent strong reference cycles.
- Moved the doThisAfter function outside the class for better organization.
- Check for self existence before performing actions inside closure to avoid potential crashes.
- Ensured optional chaining and optional binding to handle optional values more safely.
- Some other minor tweaks for better Swift conventions and readability.
- Fixed warning that would publish changes from the background thread. (Not Allowed)
video player stability fixes and some other minor tweaks
Get rid of deprecated bug reporting
- adds option to post page theme manager for inline toolbar
- conditionally displays floating pill/inline toolbar based on setting
check URL scheme so internal URLs don't crash
Revert "check URL scheme so internal URLs don't crash"
…ernal-urls

Revert "Revert "check URL scheme so internal URLs don't crash""
@frostplexx frostplexx closed this Nov 19, 2023
@ojsef39
Copy link
Member

ojsef39 commented Nov 19, 2023

@frostplexx so no icloud sync? or was that done with the export?

@frostplexx
Copy link
Member Author

iCloud sync only for API keys. It seems like it will take a while until the Defaults library supports iCloud sync so I figured I add it for the API only for the moment.

@ojsef39
Copy link
Member

ojsef39 commented Nov 19, 2023

iCloud sync only for API keys. It seems like it will take a while until the Defaults library supports iCloud sync so I figured I add it for the API only for the moment.

ahhh yeah that makes sense, thanks for clarifying :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add iCloud sync for settings / API key
7 participants