Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added f-strings to collector modules #669

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Added f-strings to collector modules #669

merged 2 commits into from
Oct 25, 2022

Conversation

Onager
Copy link
Contributor

@Onager Onager commented Oct 25, 2022

Ref styleguide change log2timeline/l2tdocs#55

@Onager Onager requested a review from tomchop October 25, 2022 07:17
tomchop
tomchop requested changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@tomchop tomchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Can you please fix the linter errors before merging?

@Onager Onager requested a review from tomchop October 25, 2022 17:31
@tomchop tomchop merged commit d12c664 into log2timeline:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchop tomchop tomchop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Onager @tomchop