feat(console,core): add attribute mapping #6916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
wangsijie,
charIeszhao,
xiaoyijun,
gao-sun and
simeng-li
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/consts/page-tabs.ts | 📈 +42 Bytes |
| packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/AttributeMapping.module.scss | 📈 +572 Bytes |
| packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/AttributeMapping.tsx | 📈 +7.49 KB |
| packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/index.tsx | 📈 +493 Bytes |
| packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/utils.ts | 📈 +350 Bytes |
| packages/core/src/saml-applications/libraries/saml-applications.ts | 📈 +50 Bytes |
| packages/integration-tests/src/tests/api/application/saml-application.test.ts | 📈 +1.62 KB |
| packages/phrases/src/locales/en/translation/admin-console/application-details.ts | 📈 +327 Bytes |
| packages/schemas/src/foundations/jsonb-types/saml-application-configs.ts | 📈 +359 Bytes |
| packages/toolkit/core-kit/src/openid.ts | 📈 +564 Bytes |
darcyYe
force-pushed
the
yemq-add-attribute-mapping
branch
from
2a93104 to
4681b0f
Compare
darcyYe
force-pushed
the
yemq-add-attribute-mapping
branch
6 times, most recently
from
2d6fcbc to
e4d40d6
Compare
darcyYe
force-pushed
the
yemq-add-attribute-mapping
branch
from
e4d40d6 to
cbc4123
Compare
charIeszhao
reviewed
Jan 3, 2025
| onClick={() => { | ||
| const currentValues = [...formValues]; | ||
| // eslint-disable-next-line @silverhand/fp/no-mutating-methods | ||
| currentValues.splice(index, 1); |
There was a problem hiding this comment.
Use slice instead of the mutating splice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PATCH /saml-applications/:idAPI, the DB query method throws error. Add integration test to cover such cases.Testing
Tested locally.
Checklist
.changeset