Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: bump minimum required version to 2021.1 #117

Merged
merged 4 commits into from
Mar 25, 2023

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Mar 21, 2023

This implements the proposed changes in #116

  • Removed the old compatibility workarounds.
  • Fixed a few compilation warnings (mostly due to deprecation).

@lppedd
Copy link
Owner

lppedd commented Mar 21, 2023

I'll handle the remaining VCS stuff if you want.

@Compatibility(minVersion = "203.4203.26")
private fun VcsLogProvider.readMetadataComp(
root: VirtualFile,
commitsHashes: List<String>,
): List<VcsCommitMetadata> {

@Compatibility(minVersion = "203.3645.34")
private fun ensureLogCreated(): Boolean {
val method =
VcsProjectLog::class.java.getDeclaredMethod("ensureLogCreated", Project::class.java) // IDEA 203.3645.34+
?: VcsProjectLog::class.java.getDeclaredMethod("getOrCreateLog", Project::class.java) // IDEA 201.3803.32+
?: VcsLogContentUtil::class.java.getDeclaredMethod("getOrCreateLog", Project::class.java)
?: return false

@bric3
Copy link
Contributor Author

bric3 commented Mar 21, 2023

Ah yes missed those, they were not listed in the problem view.

@lppedd
Copy link
Owner

lppedd commented Mar 21, 2023

Generally what I do is search for references to that annotation (I added it just for this reason).
But no worries, I'll do it and test it.

@lppedd
Copy link
Owner

lppedd commented Mar 21, 2023

I'll add commits in this PR.

bric3 added 4 commits March 25, 2023 01:12
Fixes the warning:

```
'constructor NotificationGroup(String, NotificationDisplayType, Boolean = ..., String? = ..., Icon? = ...)' is deprecated. Use com.intellij.notification.impl.NotificationGroupEP and com.intellij.notification.NotificationGroupManager
```

Refs: lppedd#116
Fixes the warning:

```
'ActionLink' is deprecated. Deprecated in Java
```

Refs: lppedd#116
@lppedd lppedd changed the title feature: Bump base version to 2021.1 feature: bump minimum required version to 2021.1 Mar 25, 2023
@lppedd lppedd merged commit a3f9285 into lppedd:master Mar 25, 2023
@bric3 bric3 deleted the bump-base branch March 29, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants