DM-42201: Add flat metrics for mean, noise vs mjd and FP plots #308
Conversation
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
3 times, most recently
from
d597a35 to
9b34d29
Compare
| @@ -90,16 +91,19 @@ class SingleValueRepacker(KeyedDataAction): | |||
|
|
|||
| def __call__(self, data: KeyedData, **kwargs) -> KeyedData: | |||
| repackedData = {} | |||
| uniquePanelKeys = list(set(data[self.panelKey])) | |||
| good = ~data[self.panelKey].mask | |||
There was a problem hiding this comment.
Unfortunately, I think (based on your jenkins failure), that you need to see if data is a numpy masked-array, and do the new thing, otherwise, default to the existing code. Hopefully that's not too difficult, and I'll re-check next week.
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
from
9b34d29 to
2f5df70
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
from
2f5df70 to
5d39a68
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
3 times, most recently
from
cd31e49 to
1e93a60
Compare
pipelines/cpCore.yaml
Outdated
| from lsst.analysis.tools.atools import * | ||
|
|
||
| analyzeFlatDetMergeCore: | ||
| class: lsst.analysis.tools.tasks.VerifyCalibAnalysisTaskByFilter |
There was a problem hiding this comment.
This is calling the existing task that only has dimensions ["instrument", "physical_filter"]. We need a new task that has input data dimensions of ["instrument", "physical_filter", "detector"].
There was a problem hiding this comment.
I think this means we need to add one more task with that set of dimensions. This all needs to be cleaned up next year to avoid this problem.
There was a problem hiding this comment.
Ah, as part of this discussion, we learned there is an existing task to do this, so if that runs, and produces plots then this should be fine.
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
2 times, most recently
from
643828b to
f5ab80f
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
from
f5ab80f to
132016e
Compare
No description provided.