DM-48137: Remove units from metric when writing to metric table #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmullaney
force-pushed
the
tickets/DM-48137
branch
3 times, most recently
from
57825c1 to
da3ee4f
Compare
jrmullaney
force-pushed
the
tickets/DM-48137
branch
from
da3ee4f to
d890729
Compare
And add the units to the column headings of the astropy Table
jrmullaney
force-pushed
the
tickets/DM-48137
branch
from
d890729 to
75c0479
Compare
kherner
approved these changes
Dec 21, 2024
| metricsDict[fullName] = [metric.quantity.value] | ||
| # "Dimensionless" and percent units not allowed in Tables: | ||
| if metric.quantity.unit is not u.dimensionless_unscaled and metric.quantity.unit is not u.pct: | ||
| metricUnits[fullName] = metric.quantity.unit |
There was a problem hiding this comment.
Would it make sense to raise some error here if the unit were not of an allowed type? At the moment, it's just as no-op.
There was a problem hiding this comment.
Thanks for querying this. dimensionless_unscaled just means the metric doesn't have a unit associated with it, so there's nothing to put in the table anyway. In that case an error or warning isn't appropriate - it would effectively be raising an error to say that a metric doesn't have a unit (which is fine).
In the case of percent, I think a warning would be more appropriate; I don't think we want to stop the use of percent units in metrics, we'd just want to warn people that this unit is not being propagated to the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.