Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/save aps #2

Open
wants to merge 30 commits into
base: release/next_release
Choose a base branch
from
Open

Release/save aps #2

wants to merge 30 commits into from

Conversation

mahmud1
Copy link
Member

@mahmud1 mahmud1 commented Aug 5, 2024

  • APS parameters are saved in step 3.
  • Pixels are selected in step 4.
  • APS is interpolated in step 4.

@mahmud1 mahmud1 requested a review from Andreas-Piter August 5, 2024 09:00
@mahmud1 mahmud1 added the enhancement New feature or request label Aug 5, 2024
@Andreas-Piter
Copy link
Member

Andreas-Piter commented Aug 6, 2024

Thanks for implementing it! I found a few locations where more changes need to be applied.

  • The mask is currently only applied for spatiotemporal unwrapping and not for spatial unwrapping. We should probably merge the two functions into one and switch between them with if-else. (We can do the same for step 2.)
  • In step 4, the APS parameters are read from file, but the type of interpolation (kriging or linear/cubic) is decided based on the config parameters of step 3. The interpolation method should be chosen only depending on the available APS parameters.
  • Skip filtering in step 4 automatically if no APS parameters are available.
  • the cohXX_aps.h5 should not be saved. It is not needed. p1_aps.h5 can be used for visualization.

The merge has to be done carefully, as several changes have been applied in parallel for the densification step.

@mahmud1
Copy link
Member Author

mahmud1 commented Aug 6, 2024

* [ ]  Skip filtering in step 4 automatically if no APS parameters are available.

In step 3, aps_parameters.h5 is created, regardless of whether skip_filter is true or false. In step 4, filtering is applied/not applied based on information in aps_parameters.h5.

@Andreas-Piter Andreas-Piter added this to the v2.0.0 milestone Oct 17, 2024
mahmud1 and others added 6 commits October 17, 2024 18:19
# Conflicts:
#	docs/demo/demo_masjed_dam_detailed_guide.rst
#	docs/processing.rst
#	sarvey/config.py
#	sarvey/densification.py
#	sarvey/processing.py
#	tests/test_processing.py
#	tests/testdata/config_test.json
# Conflicts:
#	docs/processing.rst
#	sarvey/filtering.py
#	sarvey/processing.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants