-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/save aps #2
Open
mahmud1
wants to merge
30
commits into
release/next_release
Choose a base branch
from
release/save-aps
base: release/next_release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mahmud1
commented
Aug 5, 2024
- APS parameters are saved in step 3.
- Pixels are selected in step 4.
- APS is interpolated in step 4.
Thanks for implementing it! I found a few locations where more changes need to be applied.
The merge has to be done carefully, as several changes have been applied in parallel for the densification step. |
In step 3, aps_parameters.h5 is created, regardless of whether skip_filter is true or false. In step 4, filtering is applied/not applied based on information in aps_parameters.h5. |
# Conflicts: # docs/demo/demo_masjed_dam_detailed_guide.rst # docs/processing.rst # sarvey/config.py # sarvey/densification.py # sarvey/processing.py # tests/test_processing.py # tests/testdata/config_test.json
# Conflicts: # docs/processing.rst # sarvey/filtering.py # sarvey/processing.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.