feat: use faster version of vim.validate if available
#934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaSolOs
force-pushed
the
master
branch
2 times, most recently
from
27c0949 to
413abd9
Compare
|
I think that the failing CI checks are because they're not using the updated |
lukas-reineke
requested changes
Oct 28, 2024
Thanks for the hints! :) I also want to say that I'm very impressed by your CI. I've contributed to quite a few plugins and this is a very complete testing suite! |
lukas-reineke
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The form of
vim.validatethat takes a spec table as input was deprecated in neovim/neovim#30855 and plugins should now use the faster version introduced in neovim/neovim#28977.This PR adds a new utility function to use the faster version if available. Also defined the existing
utils.validatefunction to avoid confusion with the new utility function.