-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add esp32 PSRAM support and little bug fix for lv_arduino #6
base: master
Are you sure you want to change the base?
Conversation
simonchen007
commented
Dec 31, 2020
2. add LV_LVGL_H_INCLUDE_SIMPLE for png_decoder_test.c
Hi, I think it'd be better to add a similar pattern than in lvgl. It allows platform-independent configuration. If not defined, we can use What do you think? |
Your suggestion is good if add pattern in lvgl_conf.h but need to separate it with the LVGL malloc/free. |
I meant adding similar defines for PNG. E.g. #define LV_PNG_MALLOC_INCLUDE <stdlib.h> /*Header for the dynamic memory function*/
#define LV_PNG_ALLOC malloc /*Wrapper to malloc*/
#define LV_PNG_FREE free /*Wrapper to free*/ |
That should be nice. But lv_lib_png need to be change too.
|
Yes, that's why we have this PR 😄 Or how do you mean it? |
I'm agree with you. |
Can you update the PR accordingly? |
To the LVGL main repo ? |
I mean only here by using |
should we replace malloc,free,realloc with lv_mem_alloc,lv_mem_realloc,lv_mem_free? |
This repo was just merged into the lvgl repo. See https://github.com/lvgl/lvgl/tree/master/src/extra/libs/png |