fix 0.0 pcpu issue for ps command #445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, I didn't get notifed about this at all. I'm sorry. |
|
Can you please sign-off you commit? :) |
|
Oh, I see. Thanks
|
|
Signed-off-by: LI Bo [email protected] |
fixes [lxc#444](lxc#444) Signed-off-by: LI Bo [email protected]
|
@brauner, I signed off this PR. Could you please help review? Thanks. |
|
@brauner can you take a look? |
brauner
reviewed
Mar 18, 2021
There was a problem hiding this comment.
I've reviewed this a while ago but I'm not too happy with this approach. The fix here means we're special-casing ps which I think is wrong. I would like to understand the root cause of this as this may easily happen with other tools too and we can't keep growing a list of psecial-cased tools. :)
|
Yes, this PR just fixes a special case. Looking forward to a general solution for such cases. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #444
Signed-off-by: LI Bo [email protected]