Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create StorageAccountService.cs #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lcarli
Copy link

@lcarli lcarli commented Sep 3, 2020

A service to change the way that the blog saves Posts and Files.

To use that you must change the injection into startup -> Configuration Services
services.AddSingleton<IBlogService, StorageAccountService>();

A service to change the way that the blog saves Posts and Files.

To use that you must change the injection into startup -> Configuration Services
services.AddSingleton<IBlogService, StorageAccountService>();
@madskristensen
Copy link
Owner

I don't like for MIniblog.Core to take a dependency on Azure. A better approach is to make a NuGet package with the Azure service so the user can easily replace the built-in file service with the Azure service. For that, you may need to make the built-in file service more generic, such that it can be replaced by any other storage provider.

@CeriQ
Copy link

CeriQ commented Sep 3, 2020

@madskristensen, this is very similar to a rejected PR i did a few years ago. The thing is there are no extra dependencies added, all of the APIs are in packages already a part of Miniblog.Core. Just as last time.

@madskristensen
Copy link
Owner

Ahh, got it. Sweet. We need to add some text about how to use this. Perhaps a comment in the startup class to replace file file service with this and then something about how to configure the connection string

@xaberue
Copy link

xaberue commented Aug 28, 2022

Since the projects seems a bit abandoned and I would like to recover and maintain, may I ask @lcarli to replicate this PR into the current fork? I don't want to copy paste the different code enhancements proposed in the original repository.

If at the end of this upgrade @madskristensen wants to integrate in this original repository will be more than welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants