modify to make it compatible with clonality.py #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add next(reader) to skip the headline and remove sample_1 or sample_2 from file names to locate the outputs of clonality.py
compare.repertoires.py
Outdated
|
|
||
| file_TCRB_1=args.dir_1+"/TCRB.VJ.FREQ."+sample_1+".csv" | ||
| file_TCRB_1=args.dir_1+"/TCRB.VJ.FREQ."+".csv" | ||
| file_TCRB_2=args.dir_2+"/TCRB.VJ.FREQ."+sample_2+".csv" |
There was a problem hiding this comment.
Is there a reason you didn't take out the sample_2 in this line?
There was a problem hiding this comment.
oh,my god. I forgot to remove these ones. all sample_1 or sample_2 should be removed
There was a problem hiding this comment.
Great! @mandricigor could you modify the script to amend these two lines as well and create a new pull request?
@smangul1 I don't have authorization to merge a pull request with the master branch. Can you approve it and/or add me as a contributor?
There was a problem hiding this comment.
I merged these changes with the Mangul USC lab fork.
@mandricigor, I recommend merging this patch into your fork.
@dormeight made a good fix.
remove "sample_2"
aaronkarlsberg
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add next(reader) to skip the headline and remove sample_1 or sample_2 from file names to locate the outputs of clonality.py