Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't throw an error on stderr #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hannojg
Copy link
Member

@hannojg hannojg commented Nov 22, 2024

When running release profiler i was getting errors because there was a mismatch between the react native version when it tries to run npx react-native (the cli tool prints a warning, which is in stderr in which case our lib fails and throws an error):

CleanShot 2024-11-22 at 17 41 02

i fixed this by:

  • not using npx but resolve the path to the cli manually, this way we can be sure to always use the react native version bundled with the app
  • if we were able to parse the config there is no need to throw an error, we can just print it as warning

@hannojg hannojg requested a review from Szymon20000 November 22, 2024 16:42
@hannojg
Copy link
Member Author

hannojg commented Dec 17, 2024

I know, one day the time will come where you will review @Szymon20000
And until this day I will never give up my hopes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant