improved trim by removing useless str.empty check

include/msl/utils.h

@@ -151,16 +151,14 @@ inline const char * whitespaces()
 //! @brief ltrim_in_place left trims in place 'str' of any of the 'chars' characters
 inline std::string & ltrim_in_place(std::string & str, const char * chars = whitespaces())
 {
-	if (!str.empty())
-		str.erase(0, str.find_first_not_of(chars));
+	str.erase(0, str.find_first_not_of(chars));
 	return str;
 }
 
 //! @brief rtrim_in_place right trims in place 'str' of any of the 'chars' characters
 inline std::string & rtrim_in_place(std::string & str, const char * chars = whitespaces())
 {
-	if (!str.empty())
-		str.erase(str.find_last_not_of(chars) + 1);
+	str.erase(str.find_last_not_of(chars) + 1);
 	return str;
 }
 

msl/msl_tests.cpp

@@ -38,6 +38,16 @@ int main()
 			std::cout << '"' << msl::trim(s) << '"' << '\n';
 			std::cout << '"' << msl::trim_in_place(s) << '"' << '\n';
 		}
+		{
+			auto s = " a"s;
+			std::cout << '"' << msl::trim(s) << '"' << '\n';
+			std::cout << '"' << msl::trim_in_place(s) << '"' << '\n';
+		}
+		{
+			auto s = "b "s;
+			std::cout << '"' << msl::trim(s) << '"' << '\n';
+			std::cout << '"' << msl::trim_in_place(s) << '"' << '\n';
+		}
 		{
 			auto s = "  aaa bbb ccc        "s;
 			std::cout << '"' << msl::trim(s) << '"' << '\n';
@@ -51,11 +61,11 @@ int main()
 		msl::bench([] {
 			auto s = "\n\n \n aaa  bbb  ccc  \t\t  \t   \t \n"s;
 			auto r = msl::trim(s);
-		}); //146ms
+		}); //142ms
 		msl::bench([] {
 			auto s = "\n\n \n aaa  bbb  ccc  \t\t  \t   \t \n"s;
 			auto r = msl::trim_in_place(s);
-		}); //101ms
+		}); //99ms
 	}
 	// string_replace
 	if constexpr (false)