-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ran clang-format on the entire codebase #6027
Conversation
This PR affects multiple components. |
@"MaterialActivityIndicatorInProgressAccessibilityValue", // In Progress | ||
@"MaterialActivityIndicatorAccessibilityLabel", // Activity Indicator | ||
@"MaterialActivityIndicatorProgressHaltedAccessibilityValue", // Progress Halted | ||
@"MaterialActivityIndicatorProgressCompletedAccessibilityValue", // %ld Percent Complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yaaa! 😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the caveat that we cut a hotfix release with only this change.
API diff detected the following changesActivityIndicatorMDCActivityIndicatorTransitionmodified method:
AnimationTimingUIView(MDCTimingFunction)modified category:
AppBarMDCAppBarmodified property:
modified class:
CardsMDCCardCollectionCellmodified class:
MDCCardmodified class:
ChipsMDCChipViewmodified method:
modified class:
modified method:
modified property:
modified method:
modified method:
modified method:
modified method:
FlexibleHeaderMDCFlexibleHeaderContainerViewControllermodified method:
MDCFlexibleHeaderView()new category: removed category: modified property:
ListMDCBaseCellmodified class:
SnackbarMDCSnackbarMessageView()new category: removed category: modified property:
TabsMDCTabBarIndicatorTemplatemodified protocol:
|
Detected lots of bugs in the apidiff toolchain as well! |
Filed material-motion/apidiff#27 to track. |
No description provided.