Improve merging of math lists (mathjax/MathJax#3301). #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with the merging of MathLists when multiple input jax are used. The index for the location (
startandendobjects of theMathItemobject) were not being set, and so the sorting of math items was not being done properly. This could lead to the indices within the text nodes containing the math being off when the DOM is updated, as the math is handled in the wrong order, and the text nodes are broken up, changing the character indices of the math that is out of order.This PR includes indices that can be used to sort the lists properly, and resolves issue mathjax/MathJax#3301.