Make metrics less error prone #810
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #811 due to requiring Node 14. |
AndrewFerr
requested changes
Jul 15, 2022
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| Copyright 2017 - 2019 matrix-appservice-discord | |||
| Copyright 2017 - 2019 matrix-appservice-discord, 2022 (C) The Matrix.org Foundation C.I.C. | |||
There was a problem hiding this comment.
Maybe let's just make a single change to update all of these at once 😆
| @@ -181,6 +181,16 @@ async function run(): Promise<void> { | |||
| const roomhandler = discordbot.RoomHandler; | |||
| const eventProcessor = discordbot.MxEventProcessor; | |||
|
|
|||
|
|
|||
| process.once("SIGINT", () => { | |||
There was a problem hiding this comment.
This should trigger on SIGTERM too.
| public async stop(): Promise<void> { | ||
| public stop(): void { | ||
| this.presenceHandler.Stop(); | ||
| this._bot?.destroy(); | ||
| this._bot = undefined; |
There was a problem hiding this comment.
Nitpick suggestion:
if (this._bot) {
this._bot.destroy();
this._bot = undefined;
}
since there's a branch buried in the ?. anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bridge is prone to erroring with things like:
Which is mostly due to the fact that our metrics system is:
I've also updated the matrix-appservice-bridge library to be on the latest version, I don't think it's changes will affect us too badly.