This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Load web workers and worklets in a way that Webpack 5 can bundle them #11869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 01a62b36a484d65664a641c4db2a7f3373251b47 Merge: 10edf06 74961db Author: Johannes Marbach <[email protected]> Date: Mon Nov 13 19:38:47 2023 +0100 Merge branch 'johannes/webpack5-workers' into johannes/worklet-path commit 10edf06 Author: Johannes Marbach <[email protected]> Date: Sun Nov 12 12:21:43 2023 +0100 Document syntax and use .ts commit 4040f2c Author: Johannes Marbach <[email protected]> Date: Sat Nov 11 21:38:09 2023 +0100 Switch to URL and use syntax compatible with Webpack commit b4f96f1 Merge: eed2ffd 9448469 Author: Johannes Marbach <[email protected]> Date: Thu Nov 9 21:04:06 2023 +0100 Merge branch 'develop' into johannes/worklet-path commit eed2ffd Author: Johannes Marbach <[email protected]> Date: Thu Nov 9 21:03:45 2023 +0100 Restore unused import to fix dead code analysis commit 689cea2 Author: Johannes Marbach <[email protected]> Date: Thu Nov 9 16:50:56 2023 +0100 Use literal path in audioWorklet.addModule for compatibility with Webpack 5
Johennes
added
the
T-Task
This was referenced Nov 14, 2023
t3chguy
approved these changes
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: element-hq/element-web#26229
This changes the way web workers and worklets are loaded to be compatible with Webpack 5's built-in support for workers and worklets. This in turn allows us to get rid of worker-loader and worklet-loader.
Remaining issues:
import.meta.urlcauses an IDE warning:The 'import.meta' meta-property is only allowed when the '--module' option is 'es2020', 'es2022', 'esnext', 'system', 'node16', or 'nodenext'.ts(1343)Requires: element-hq/element-web#26551
This change is marked as an internal change (Task), so will not be included in the changelog.