Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified kata requirements and fixed tests for conjured items. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

k-hoszowski
Copy link

In the repo this was taken from, namely https://github.com/istepaniuk/gilded-rose-js-with-tests it says:

Note that this Kata has been slightly modified from the original by Terry Hughes and Bobby Johnson. Namely, in the original Kata the Brie Cheese does not behave exactly like the Backstage passes as this code does.

This should be indicated in this repo as well. I also noticed that tests for conjured items were the wrong way around: the quality is being deducted twice as fast in the wrong test. Because of this change, the unskipped test will return an error for the starter code. It can be commented out, but perhaps there's a better way I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant