Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds 8 controller entries for macOS #584

Merged
merged 5 commits into from
Jun 12, 2022
Merged

adds 8 controller entries for macOS #584

merged 5 commits into from
Jun 12, 2022

Conversation

stevenjamescox
Copy link
Contributor

@stevenjamescox stevenjamescox commented Jun 11, 2022

adds the following controller entries for macOS:

  • Hyperkin N64 Controller Adapter
    • used to connect a standard N64 controller to a device via USB
    • one entry is for PC Mode, the other for Console Mode (there's a small toggle switch on the adapter)
  • Unbranded/Generic N64 USB Controller
    • apparently its hardware device IDs (vendor 121, product 6) are used by a variety of generic USB controllers out there, but its addition doesn't create any SDL GUID conflicts
  • Sega Genesis Mini Official Controller
  • 8BitDo M30 2.4 GHz for Sega Genesis Mini
  • SteelSeries Stratus Duo
    • one entry is for utilizing its included 2.4 GHz USB receiver, the other is for connecting via a micro USB cable
    • in both such modes it operates as an Xinput controller and thus requires a modified 360Controller.kext (or other such driver) to actually use, but such is also the case with several other controllers currently in the database under macOS so it did not seem inappropriate to add them
    • this controller is also capable of connecting via Bluetooth, but will not stay legitimately connected in macOS
  • Retro-Bit Sega Genesis 6-button Arcade Pad with USB

@offalynne
Copy link
Collaborator

offalynne commented Jun 11, 2022

Thank you for taking the time to find missing devices and mapping them carefully and correctly!

Unfortunately the unbranded N64 pad does not look to be reliably identifiable on that GUID alone as even the version/bcdDevice field is not unique: https://bit.ly/3mEd9zz

I've removed that mapping but otherwise looks good. Will merge shortly.

@stevenjamescox
Copy link
Contributor Author

My pleasure. Thank you for cleaning 'em up!

@offalynne offalynne merged commit 360c596 into mdqinc:master Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants